expose readiness failures when application metadata is unavailable - #69

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@jules Please review and address the following items for this PR:

Issues to Fix

1. PostgreSQL Compatibility in Readiness Probe:
   • In app/services/database/connection.py:456, check_db_readiness() Step 2 queries SQLite metadata even when is_postgres() == True. Ensure Step 2 executes PostgreSQL-compatible schema checks against the PostgreSQL connection when running against Postgres.
2. PostgreSQL Readiness Test:
   • Add a mock/isolated test for PostgreSQL readiness checks in tests/backend/test_health_check_status.py.
3. Requirement Traceability:
   • Tag tests with @pytest.mark.requirement("HEALTH-READY-01").
   • Re-run python3 scripts/generate_requirements.py.

How to Confirm the Fix

Run the following commands to confirm everything passes:

pytest tests/backend/test_health_check_status.py -v
python3 scripts/generate_requirements.py
pytest tests/backend/test_requirements_sync.py